UsernameAvailability Work Item Rss Feed

Closed Issue: Control keys shouldn't trigger validation

Encosia — Sun, 28 Sep 2008 19:52:49 GMT

Control keys (arrows, tab, enter, ctrl, shift, home, end, etc) should not trigger validation. Currently, when ValidateOnKeyPress is true, they do.

Closed Issue: Error occurs when changing username entry during AJAX Request

Encosia — Sun, 28 Sep 2008 19:47:54 GMT

I encountered this issue while I was trying to enter UserName very quickly. The AJAX request is initiated and I was trying to continue editing the UserName which cases another AJAX request to be imitated while the 1st one is not completed yet. Or at least this is what I guess.
ValidateOnKeyPress is set to True
KeyPressDelay is set to 200. However when I increased this value to 1000 the delay between key press prevent this issue to take place. But I was able to reproduce it when I made the execution of the service to take much longer so that the delay has no effect at this case as the new AJAX request is initiated before the previous one completes.
Comments: Appears to be resolved. Re-open if anyone is able to reproduce on the latest version.

Commented Issue: Error occurs when changing username entry during AJAX Request

mosessaur — Wed, 24 Sep 2008 15:43:15 GMT

I tested this after downloading latest source. It works fine no Error (alert) message displayed. I set a delay on the Web Service Method as well using Sleep method. Many Ajax Requests are initiated when the KeyPressDelay and MinimumLength is too small, but no exceptions or errors occur.
I recommend to make the Minimum value for KeyPressDelay 500 ms.

Commented Issue: Control keys shouldn't trigger validation

Encosia — Tue, 23 Sep 2008 00:08:21 GMT

Control keys (arrows, tab, enter, ctrl, shift, home, end, etc) should not trigger validation. Currently, when ValidateOnKeyPress is true, they do.
Comments: ** Comment from web user: Encosia **

Checkin #40438 includes caching code to avoid duplicate lookups caused by these control keys. However, it might be preferable to check for the actual key being pressed and NOOP the validation completely if it's something like an arrow key. The Sys.UI.Key enum makes doing this relatively painless and clean.

Commented Issue: Error occurs when changing username entry during AJAX Request

Encosia — Tue, 23 Sep 2008 00:03:40 GMT

jnagy's improvements in #40438 seem to fix this. I'm unable to reproduce.

However, the requests do *not* appear to be aborting on the client side. If there are still problems, we might need to investigate calling the service through the XmlHttpExecutor class instead of WebServiceProxy. I believe it has better abort support.

So, is anyone able to reproduce the error, using #40438?

Closed Issue: Timeout and WebRequest Should be Cleared On Disposal

Encosia — Mon, 22 Sep 2008 23:58:25 GMT

The timeout created by the onkeypress and the active availability web request need to be cleared or destroyed during the control's dispose method. If we don't do this, the timeout could expire or web request's response methods could execute unexpectedly with unintended outcomes.
Comments: Completed by jnagy, in #40438.

Commented Issue: Implement minimum length validation

Encosia — Mon, 22 Sep 2008 23:37:47 GMT

Per the thread in discussions, since we're already tracking a desired minimum length, let's validate for that condition as well. Need to implement client and server side validation for ControlToValidate.Text.Length >= MinimumLength.
Comments: ** Comment from web user: Encosia **

What I mean is that we should consider a less-than-minimum-length situation to be invalid.

Commented Issue: Implement minimum length validation

jnagy — Mon, 22 Sep 2008 20:32:55 GMT

I think, it has been already implemented both on sever and client side.
On client side it is in the _onValidate method : this._controlToValidate.value.length >= this.get_MinimumLength()
On server side the IsUsernameAvailable method contains a check for
if(!string.IsNullOrEmpty(controlValidationValue) && controlValidationValue.Length >= MinimumLength)
But let me know if I am wrong.

Created Issue: Implement minimum length validation

Encosia — Mon, 22 Sep 2008 17:51:36 GMT

Commented Issue: Error occurs when changing username entry during AJAX Request

JRumerman — Mon, 22 Sep 2008 05:37:00 GMT

Shouldn't the webrequest.abort code that's in the _doValidate method handle this situation? The second _doValidate fires, the response of the first _doValidate hasn't been received so the code aborts the first webrequest (which is probably just marking it to ignore the response), and then the second one begins to execute.

Is anybody 100% that the abort method does what we think it does (and works properly) and the onsuccess or onfailure methods attached to its response, won't execute when the response is received?

Just to make sure I've got the problem right, it sounds like you're describing an issue where the web service takes longer to respond than the time it takes to initiate another request. Is that correct? If so, I think an easy way to test for this problem is to put a sleep in the web service so it takes a while to respond. The first response should then be ignored.

Created Issue: Timeout and WebRequest Should be Cleared On Disposal

JRumerman — Mon, 22 Sep 2008 05:27:50 GMT

Closed Issue: _doValidate should not be triggered for an empty username

Encosia — Fri, 19 Sep 2008 17:51:15 GMT

Currently, if the TextBox is cleared, a validation call will occur for the empty username. This doesn't specifically hurt anything, but we should eliminate the redundant web service call in that case.

Created Issue: Control keys shouldn't trigger validation

Encosia — Fri, 19 Sep 2008 17:15:22 GMT

Control keys (arrows, tab, enter, ctrl, backspace, delete, shift, home, end, etc) should not trigger validation. Currently, when ValidateOnKeyPress is true, they do.

Commented Task: Implement SuccessMessage property

mosessaur — Thu, 18 Sep 2008 23:45:39 GMT

In addition to the ErrorMessage property in BaseValidator, we need to add an additional string property to contain the message used to reflect an available username.
Comments: ** Comment from web user: mosessaur **

It should have its own style properties too. or at least CssClass property.

Created Issue: Error occurs when changing username entry during AJAX Request

mosessaur — Thu, 18 Sep 2008 23:39:44 GMT

Created Task: Implement SuccessMessage property

Encosia — Thu, 18 Sep 2008 14:18:45 GMT

In addition to the ErrorMessage property in BaseValidator, we need to add an additional string property to contain the message used to reflect an available username.

Closed Issue: ServicePath doesn't handle application relative path (~/)

Encosia — Wed, 17 Sep 2008 22:31:59 GMT

The ServicePath property should use ResolveUrl() to properly translate paths that contain a ~/ type path. Be sure to test this with site, application, and document relative paths.

Created Issue: _doValidate should not be triggered for an empty username

Encosia — Wed, 17 Sep 2008 21:53:58 GMT

Created Issue: Parameter case sensitivity when calling web service

Encosia — Tue, 16 Sep 2008 20:31:45 GMT

Currently, the web service's username parameter is case sensitive. This is likely to lead to confusion for developers implementing the web service to use our control. Any efforts to overcome this limitation would be helpful.

Created Issue: ServicePath doesn't handle application relative path (~/)

Encosia — Tue, 16 Sep 2008 20:20:44 GMT

The ServicePath property should use ResolveUrl() to properly translate paths that contain a ~/ type path. Be sure to test this with site, application, and document relative paths.